[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86
    Orlando Cazalet-Hyams via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Nov 29 06:27:52 PST 2021
    
    
  
Orlando added a comment.
Driver flag change seems ok but would appreciate another pair of eyes checking it makes sense. Everything else (test change omissions, new test, default flag settings) LGTM.
================
Comment at: llvm/lib/Target/X86/X86TargetMachine.cpp:29
 #include "llvm/Analysis/TargetTransformInfo.h"
+#include "llvm/CodeGen/CommandFlags.h"
 #include "llvm/CodeGen/ExecutionDomainFix.h"
----------------
nit: Is this change necessary?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114631/new/
https://reviews.llvm.org/D114631
    
    
More information about the llvm-commits
mailing list