[PATCH] D114437: [Support][CMake] Fix exposed absolute path dependency of terminfo library

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 11:05:17 PST 2021


compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

I'm not sure that this is a good idea.  This now means that you can link against two different versions of this library - one when building LLVMSupport and one that any user linking against LLVMSupport happens to find in the library search path.  Consider someone explicitly providing a path to the terminfo library when configuring.  At the very least, the library search path should be propagated to ensure that the right version is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114437/new/

https://reviews.llvm.org/D114437



More information about the llvm-commits mailing list