[PATCH] D114437: [Support][CMake] Fix exposed absolute path dependency of terminfo library

xndcn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 23 06:30:29 PST 2021


xndcn created this revision.
xndcn added reviewers: sepavloff, compnerd, phosek.
Herald added subscribers: pengfei, hiraditya, kristof.beyls, mgorny.
xndcn requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

terminfo library dependency is exposed as absolute path in "LLVMExports.cmake".

clang+llvm-13.0.0-x86_64-apple-darwin.tar.xz/lib/cmake/llvm/LLVMExports.cmake:

  set_target_properties(LLVMSupport PROPERTIES
    INTERFACE_LINK_LIBRARIES "m;ZLIB::ZLIB;/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib/libcurses.tbd;LLVMDemangle"
  )

clang+llvm-13.0.0-aarch64-linux-gnu.tar.xz/lib/cmake/llvm/LLVMExports.cmake:

  set_target_properties(LLVMSupport PROPERTIES
    INTERFACE_LINK_LIBRARIES "rt;dl;-lpthread;m;ZLIB::ZLIB;/usr/lib/aarch64-linux-gnu/libtinfo.so;LLVMDemangle"
  )


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114437

Files:
  llvm/lib/Support/CMakeLists.txt


Index: llvm/lib/Support/CMakeLists.txt
===================================================================
--- llvm/lib/Support/CMakeLists.txt
+++ llvm/lib/Support/CMakeLists.txt
@@ -45,7 +45,8 @@
     set(system_libs ${system_libs} ${Backtrace_LIBFILE})
   endif()
   if( LLVM_ENABLE_TERMINFO )
-    set(imported_libs ${imported_libs} "${TERMINFO_LIB}")
+    get_library_name(${TERMINFO_LIB} terminfo_library)
+    set(imported_libs ${imported_libs} "${terminfo_library}")
   endif()
   if( LLVM_ENABLE_THREADS AND (HAVE_LIBATOMIC OR HAVE_CXX_LIBATOMICS64) )
     set(system_libs ${system_libs} atomic)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114437.389182.patch
Type: text/x-patch
Size: 604 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211123/52ba8cb2/attachment.bin>


More information about the llvm-commits mailing list