[PATCH] D114272: [InstCombine] Add two optimizations for mul-and-icmp patterns

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/pr40493.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -instcombine -S | FileCheck %s
----------------
fwolff wrote:
> lebedev.ri wrote:
> > Precommit tests please
> Do you mean that I should submit this file separately first in a different revision?
This was answered in another comment, but to clarify:

Yes - this means (1) create the tests, (2) auto-generate the baseline (without this code change) CHECK lines, (3) commit that, and (4) rebase this patch so we just see the diffs from the baseline results in this review.

I prefer a pattern-based rather than PR-based file name (it may be possible to just add the tests to an existing file with tests for related transforms). It's also nicer to have descriptive function names rather than the anonymous `@test...`.

Ideally, you can push the baseline tests to the main branch. Have you requested/received commit access yet?
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114272/new/

https://reviews.llvm.org/D114272