[PATCH] D114272: [InstCombine] Add two optimizations for mul-and-icmp patterns

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 07:09:21 PST 2021


spatel added a comment.

Note: the existing transform to trunc was removed with f55d1eb3746a <https://reviews.llvm.org/rGf55d1eb3746a17688ca10d4e699ccea7d0f15378> , so this patch will need to be updated to account for that.

I suspect we need a "hasOneUse" check on the multiply on at least the first transform in this patch, but we should have tests for those patterns either way. It would be easier to review all the permutations if the tests are pre-committed, and this patch is split in 2 pieces (one for each transform).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114272/new/

https://reviews.llvm.org/D114272



More information about the llvm-commits mailing list