[PATCH] D111051: [mlir][OpenMP] Add support for SIMD modifier

Peixin Qiao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 28 04:22:38 PST 2021


peixin added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:691
   if (schedule == omp::ClauseScheduleKind::Static) {
     ompBuilder->applyStaticWorkshareLoop(ompLoc.DL, loopInfo, allocaIP,
                                          !loop.nowait(), chunk);
----------------
Leporacanthicus wrote:
> peixin wrote:
> > The simd modifier info is not passed to `applyStaticWorkshareLoop`. That is, the schedule type of StaticBalancedChunked is not handled and checked. Considering this function is refactored in https://reviews.llvm.org/D114413. Maybe you can merge this patch, and let it to be handled in D114413.
> Thanks for the LGTM. I've pushed this patch, and if you are happy to do that in D114413, then do that - or we can fix it in a different patch. 
OK. It is better to let one patch focus on one thing. Please remember to make this fix after D114413 is accepted and merged.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111051/new/

https://reviews.llvm.org/D111051



More information about the llvm-commits mailing list