[PATCH] D111051: [mlir][OpenMP] Add support for SIMD modifier

[Mats Petersson via Phabricator via llvm-commits]

Leporacanthicus marked an inline comment as done.
Leporacanthicus added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:691
   if (schedule == omp::ClauseScheduleKind::Static) {
     ompBuilder->applyStaticWorkshareLoop(ompLoc.DL, loopInfo, allocaIP,
                                          !loop.nowait(), chunk);
----------------
peixin wrote:
> The simd modifier info is not passed to `applyStaticWorkshareLoop`. That is, the schedule type of StaticBalancedChunked is not handled and checked. Considering this function is refactored in https://reviews.llvm.org/D114413. Maybe you can merge this patch, and let it to be handled in D114413.
Thanks for the LGTM. I've pushed this patch, and if you are happy to do that in D114413, then do that - or we can fix it in a different patch. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111051/new/

https://reviews.llvm.org/D111051