[PATCH] D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 27 11:59:44 PST 2021


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5463
   }
+  if (Name.startswith("NetBSD-CORE") && ELFType == ELF::ET_CORE) {
+    StringRef Result = FindNote(NetBSDCoreNoteTypes);
----------------
Check `ELFType == ELF::ET_CORE` first to skip string comparison for the majority cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114635/new/

https://reviews.llvm.org/D114635



More information about the llvm-commits mailing list