[PATCH] D114635: [llvm-readobj] Add support for machine-independent NetBSD ELF core notes.

[Frederic Cambus via Phabricator via llvm-commits]

fcambus marked 2 inline comments as done.
fcambus added a comment.

Here is a new revision with the trailing spaces removed and linting
issue fixed, and updated tests.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5462
   }
+  if (Name.startswith("NetBSD-CORE") && ELFType == ELF::ET_CORE) {
+    StringRef Result = FindNote(NetBSDCoreNoteTypes);
----------------
MaskRay wrote:
> Is it `startswith`? The test doesn't have a case for `NetBSD-CORE` with a suffix.
Yes, startswith is required as some notes have names of the form `NetBSD-CORE at nn` where `nn` is the LWP ID of the execution context.

But you are right, the test was wrong for `NT_NETBSDCORE_LWPSTATUS` notes, sorry about that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114635/new/

https://reviews.llvm.org/D114635