[PATCH] D114641: [LNT] Remove `nm` dependency, used `objdump –t` instead

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 26 06:59:32 PST 2021


kpdev42 created this revision.
kpdev42 added reviewers: cmatthews, thopre, danilaml.
kpdev42 added a project: LLVM.
Herald added subscribers: dkolesnichenko, pengfei, kristof.beyls.
kpdev42 requested review of this revision.

It is necessary to use the correct `nm` and `objdump` for some targets (for example ARM thumb).
Wrong `nm` can provide an information but addresses may be wrong. The correct `nm` for ARM will report the address 0x1234 for a thumb binary, but system’s `nm` (x86) will report the address 0x1235.
It is very hard to investigate such issues. We suggest to remove `nm` dependency at all and use `objdump -t` instead.
Note objdump allows demangling too. It makes the profile page more human friendly.
Here is the objdump -t output format for reference https://github.com/llvm-mirror/llvm/blob/2c4ca6832fa6b306ee6a7010bfb80a3f2596f824/tools/llvm-objdump/llvm-objdump.cpp#L1850

OS Laboratory. Huawei Russian Research Institute. Saint-Petersburg


Repository:
  rLNT LNT

https://reviews.llvm.org/D114641

Files:
  lnt/server/ui/profile_views.py
  lnt/server/ui/static/lnt_profile.js
  lnt/testing/profile/cPerf.cpp
  lnt/testing/profile/perf.py
  lnt/testing/profile/profile.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114641.390044.patch
Type: text/x-patch
Size: 10919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211126/c37c4cc2/attachment.bin>


More information about the llvm-commits mailing list