[PATCH] D114364: [DebugInfo][5/N] Recognise extra indirection in instruction-referencing for NRVO tests

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D114364#3154256 <https://reviews.llvm.org/D114364#3154256>, @jmorse wrote:

> IMO these tests would benefit little as they're really targetted at LiveDebugValues, and shouldn't really be .ll tests. On the other hand, given that there isn't actually a test difference between the two implementations, it won't hurt to add some extra RUN lines, WDYT?

If I understand right, these tests do cover behaviour in the VarLocBasedImpl that we want to maintain - without the extra run lines, someone could theoretically run through the VarLoc impl and delete the "add a deref when spilling already-indirect offsets" code, and that would no longer cause a test failure as of this patch. If I've understood incorrectly then the patch LGTM, otherwise I think it'd be good to have the extra run lines (and with those lines, LGTM).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114364/new/

https://reviews.llvm.org/D114364