[PATCH] D114364: [DebugInfo][5/N] Recognise extra indirection in instruction-referencing for NRVO tests

Thu Nov 25 09:17:41 PST 2021

jmorse added a comment.

In D114364#3154243 <https://reviews.llvm.org/D114364#3154243>, @StephenTozer wrote:

> Would it make sense to have these tests run twice, once with experimental-debug-variable-locations being true and once with false? Otherwise it looks like they will no longer cover the normal DBG_VALUE case with this patch.

Sometimes yes, sometimes no, see discussion with Orlando here: https://reviews.llvm.org/D114362#3151143

IMO these tests would benefit little as they're really targetted at LiveDebugValues, and shouldn't really be .ll tests. On the other hand, given that there isn't actually a test difference between the two implementations, it won't hurt to add some extra RUN lines, WDYT?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114364/new/

https://reviews.llvm.org/D114364