[PATCH] D114460: [fir] Add fir reduction builder

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 4 inline comments as done.
clementval added inline comments.


================
Comment at: flang/unittests/Optimizer/Builder/Runtime/ReductionTest.cpp:20
+  mlir::Value all = fir::runtime::genAll(*firBuilder, loc, undef, dim);
+  checkCallOp(all.getDefiningOp(), "_FortranAAll", 2);
+}
----------------
awarzynski wrote:
> Same suggestion in other places.
Does this really help?


================
Comment at: flang/unittests/Optimizer/Builder/Runtime/ReductionTest.cpp:25-26
+  auto loc = firBuilder->getUnknownLoc();
+  mlir::Type seqTy =
+      fir::SequenceType::get(fir::SequenceType::Shape(1, 10), i32Ty);
+  mlir::Value result = firBuilder->create<fir::UndefOp>(loc, seqTy);
----------------
awarzynski wrote:
> Move next to other "// Commonly used types" in `RuntimeCallTest`?
Are you talking about `seqTy` or `result`? Not sure if the comment moved with the update. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114460/new/

https://reviews.llvm.org/D114460