[PATCH] D114460: [fir] Add fir reduction builder

Thu Nov 25 03:42:55 PST 2021

clementval added a comment.

In D114460#3153122 <https://reviews.llvm.org/D114460#3153122>, @kiranchandramohan wrote:

> In D114460#3152380 <https://reviews.llvm.org/D114460#3152380>, @clementval wrote:
>
>> In D114460#3151536 <https://reviews.llvm.org/D114460#3151536>, @kiranchandramohan wrote:
>>
>>> If `RuntimeCalltestBase` can be factored out into a separate patch, the other patches can be tested or reviewed independently.
>>
>> Should I move `flang/include/flang/Optimizer/Builder/Runtime/RTBuilder.h` as well to the initial patch? It would makes sense since all other need this file.
>
> Yes, that would be good. You can cite other patches which are consumers.

`RTBuilder.h` moved to D114557 <https://reviews.llvm.org/D114557>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114460/new/

https://reviews.llvm.org/D114460