[PATCH] D114101: [SLP]Improve analysis/emission of vector operands for alternate nodes.

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 24 10:46:35 PST 2021


vporpo accepted this revision.
vporpo added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5049
+      // main/alternate ops.
+      auto &&ExistMatchingNode = [this, E]() {
+        for (const std::unique_ptr<TreeEntry> &TE : VectorizableTree) {
----------------
Nit: Perhaps rename `ExistsMatchingNode` to something a bit less ambiguous, for example like `FoundDiamondMatch` or  `FoundMatchingShuffle` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114101/new/

https://reviews.llvm.org/D114101



More information about the llvm-commits mailing list