[llvm] b861c36 - Fix -Wparentheses warnings. NFC.
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 23 13:32:31 PST 2021
Lang: Looks like the count_if could be replaced with none_of?
On Wed, Nov 17, 2021 at 12:32 PM Michael Liao via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
>
> Author: Michael Liao
> Date: 2021-11-17T15:30:38-05:00
> New Revision: b861c3600c4a684dcfabf84e2482c34d16dd94ce
>
> URL:
> https://github.com/llvm/llvm-project/commit/b861c3600c4a684dcfabf84e2482c34d16dd94ce
> DIFF:
> https://github.com/llvm/llvm-project/commit/b861c3600c4a684dcfabf84e2482c34d16dd94ce.diff
>
> LOG: Fix -Wparentheses warnings. NFC.
>
> Added:
>
>
> Modified:
> llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
>
> Removed:
>
>
>
>
> ################################################################################
> diff --git a/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
> b/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
> index 6087861ff7362..83d85953fce69 100644
> --- a/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
> +++ b/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
> @@ -1120,11 +1120,11 @@ class LinkGraph {
> Symbol &addDefinedSymbol(Block &Content, JITTargetAddress Offset,
> StringRef Name, JITTargetAddress Size, Linkage
> L,
> Scope S, bool IsCallable, bool IsLive) {
> - assert(S == Scope::Local || llvm::count_if(defined_symbols(),
> - [&](const Symbol *Sym) {
> - return Sym->getName() ==
> Name;
> - }) == 0 &&
> - "Duplicate defined symbol");
> + assert((S == Scope::Local || llvm::count_if(defined_symbols(),
> + [&](const Symbol *Sym) {
> + return Sym->getName()
> == Name;
> + }) == 0) &&
> + "Duplicate defined symbol");
> auto &Sym =
> Symbol::constructNamedDef(Allocator.Allocate<Symbol>(), Content,
> Offset,
> Name, Size, L, S, IsLive, IsCallable);
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211123/6d841273/attachment.html>
More information about the llvm-commits
mailing list