<div dir="ltr">Lang: Looks like the count_if could be replaced with none_of?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 17, 2021 at 12:32 PM Michael Liao via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Michael Liao<br>
Date: 2021-11-17T15:30:38-05:00<br>
New Revision: b861c3600c4a684dcfabf84e2482c34d16dd94ce<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/b861c3600c4a684dcfabf84e2482c34d16dd94ce" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b861c3600c4a684dcfabf84e2482c34d16dd94ce</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/b861c3600c4a684dcfabf84e2482c34d16dd94ce.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b861c3600c4a684dcfabf84e2482c34d16dd94ce.diff</a><br>
<br>
LOG: Fix -Wparentheses warnings. NFC.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h b/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h<br>
index 6087861ff7362..83d85953fce69 100644<br>
--- a/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h<br>
+++ b/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h<br>
@@ -1120,11 +1120,11 @@ class LinkGraph {<br>
   Symbol &addDefinedSymbol(Block &Content, JITTargetAddress Offset,<br>
                            StringRef Name, JITTargetAddress Size, Linkage L,<br>
                            Scope S, bool IsCallable, bool IsLive) {<br>
-    assert(S == Scope::Local || llvm::count_if(defined_symbols(),<br>
-                                               [&](const Symbol *Sym) {<br>
-                                                 return Sym->getName() == Name;<br>
-                                               }) == 0 &&<br>
-                                    "Duplicate defined symbol");<br>
+    assert((S == Scope::Local || llvm::count_if(defined_symbols(),<br>
+                                                [&](const Symbol *Sym) {<br>
+                                                  return Sym->getName() == Name;<br>
+                                                }) == 0) &&<br>
+           "Duplicate defined symbol");<br>
     auto &Sym =<br>
         Symbol::constructNamedDef(Allocator.Allocate<Symbol>(), Content, Offset,<br>
                                   Name, Size, L, S, IsLive, IsCallable);<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>