[PATCH] D114340: [COFF] [ARM64] Create symbols with regular intervals for relocations against temporary symbols

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 23 00:11:49 PST 2021


mstorsjo added inline comments.


================
Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:155-156
 
   bool UseBigObj;
+  bool UseOffsetLabels;
 
----------------
rnk wrote:
> These should both really have default member initializers (`= false`). Looking at the constructor, it's not at all clear how `UseBigObj` is initialized.
> 
> I thought this was part of CodingStandards, but I don't see it there. *shrug*
I'll add a default initialization of the newly added variable here just for clarity, but I'm leaving the existing code as is for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114340/new/

https://reviews.llvm.org/D114340



More information about the llvm-commits mailing list