[PATCH] D114340: [COFF] [ARM64] Create symbols with regular intervals for relocations against temporary symbols

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Just nits



================
Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:155-156
 
   bool UseBigObj;
+  bool UseOffsetLabels;
 
----------------
These should both really have default member initializers (`= false`). Looking at the constructor, it's not at all clear how `UseBigObj` is initialized.

I thought this was part of CodingStandards, but I don't see it there. *shrug*


================
Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:167
 
   void reset() override {
     memset(&Header, 0, sizeof(Header));
----------------
This looks like it should re-initialize `UseBigObj`, and maybe some other fields... I'm not sure what codepath exercises this reset method (maybe LTO, since it emits multiple objects in process?), but it seems buggy and beyond the scope of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114340/new/

https://reviews.llvm.org/D114340