[PATCH] D114286: [memprof] Extend llvm-profdata to display MemProf profile summaries.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/ProfileData/RawMemProfReader.cpp:33
+
+  return Summary{
+      Header->version,
----------------
This assumes one Header in the profile, but it is possible to have multiple raw profiles concatenated in the same file?


================
Comment at: llvm/lib/ProfileData/RawMemProfReader.cpp:74
+    auto *Header = reinterpret_cast<const memprof::Header *>(Next);
+    TotalSize += Header->total_size;
+    Next += Header->total_size;
----------------
Add checks to Headers here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114286/new/

https://reviews.llvm.org/D114286