[PATCH] D114286: [memprof] Extend llvm-profdata to display MemProf profile summaries.
Snehasish Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 22 13:17:48 PST 2021
snehasish added a comment.
In D114286#3144112 <https://reviews.llvm.org/D114286#3144112>, @davidxl wrote:
> Probably better to split out the refactor patch and commit it separately as NFC.
I tried it out and decided against it for the following reasons:
- IMO we should introduce both shared .inc files in a single commit.
- If I move both refactored inc files into a separate commit, to keep it NFC the file in include/llvm/ProfileData will be unused.
Finally, since the size of the refactored out content isn't large (<50 LOC) I'd like to keep this as is unless you have a strong opinion.
PTAL, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114286/new/
https://reviews.llvm.org/D114286
More information about the llvm-commits
mailing list