[PATCH] D114172: [ARM] implement support for ALU/LDR PC-relative group relocations

Mon Nov 22 11:03:36 PST 2021

MaskRay added a comment.

> https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=5d43c8cff9ed3edb37456fddc0ec2db77d219e7d

The page says "Notice: this object is not reachable from any branch." Since it is not in torvalds/master, I assume the link may be dangling in the future after your branch is force pushed.
Perhaps mention the subject so that it can be found for archaeology.

================
Comment at: lld/ELF/Arch/ARM.cpp:431
+    rem = val;
+    val &= (uint64_t)0xffffffU >> lz;
+  } while (group--);
----------------
MaskRay wrote:
> 
val is uint32_t. Remove `(uint64_t)`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114172/new/

https://reviews.llvm.org/D114172