[PATCH] D114172: [ARM] implement support for ALU/LDR PC-relative group relocations
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 22 10:34:09 PST 2021
MaskRay added inline comments.
================
Comment at: lld/ELF/Arch/ARM.cpp:447
+ uint32_t imm;
+ unsigned lz = getRemainderForGroup(group, val, imm);
+ unsigned rot = 0;
----------------
Does it make sense to change all `unsigned` in this function and `getRemainderForGroup` to `uint32_t`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114172/new/
https://reviews.llvm.org/D114172
More information about the llvm-commits
mailing list