[PATCH] D114371: [Flang] Replace notifyMatchFailure with TODO hard failures

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:786
                   mlir::ConversionPatternRewriter &rewriter) const override {
-    return rewriter.notifyMatchFailure(
-        dispatch, "fir.dispatch codegen is not implemented yet");
+    TODO(dispatch.getLoc(), "fir.dispatch codegen");
+    return failure();
----------------
clementval wrote:
> awarzynski wrote:
> > How about a test for this one?
> `flang/test/Fir/Todo/dispatch.fir`
My bad, missed it, thanks!


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:800
                   mlir::ConversionPatternRewriter &rewriter) const override {
-    return rewriter.notifyMatchFailure(
-        dispTab, "fir.dispatch_table codegen is not implemented yet");
+    TODO(dispTab.getLoc(), "fir.dispatch_table codegen");
+    return failure();
----------------
clementval wrote:
> awarzynski wrote:
> > A test file?
> `flang/test/Fir/Todo/dispatch_table.fir`
My bad, missed it, thanks!


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1563
+    if (isDerivedTypeWithLenParams(boxTy)) {
+      TODO(embox.getLoc(), "fir.embox codegen of derived with length parameters");
+      return failure();
----------------
clementval wrote:
> awarzynski wrote:
> > Test?
> This is one of the case where the type conversion will failed first before reaching this point. 
Ta! Could this be documented in the summary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114371/new/

https://reviews.llvm.org/D114371