[PATCH] D114371: [Flang] Replace notifyMatchFailure with TODO hard failures

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 09:42:50 PST 2021


clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1563
+    if (isDerivedTypeWithLenParams(boxTy)) {
+      TODO(embox.getLoc(), "fir.embox codegen of derived with length parameters");
+      return failure();
----------------
awarzynski wrote:
> Test?
This is one of the case where the type conversion will failed first before reaching this point. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114371/new/

https://reviews.llvm.org/D114371



More information about the llvm-commits mailing list