[PATCH] D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 00:43:49 PST 2021


jhenderson added a comment.

In D82549#3143604 <https://reviews.llvm.org/D82549#3143604>, @DiggerLin wrote:

> @jhenderson , I am so sorry that delay so long to address comment,  when I tried to revert the patch, but I found  patch https://reviews.llvm.org/D111487 "[XCOFF][yaml2obj] support for the auxiliary file header." is depend on the patch and it commit. if I revert the patch , I have to revert the patch D111487 <https://reviews.llvm.org/D111487> too. 
> Base on current situation , it maybe better to create a NFC patch to address your comments (after commit) for the patch ?  what is your suggestion ?

Creating a new patch would be acceptable, yes. I'd suggest that, instead of additional reverts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82549/new/

https://reviews.llvm.org/D82549



More information about the llvm-commits mailing list