[PATCH] D113104: add the xcoff symbol size for the llvm-nm.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/size.test:17-22
+# NM-SIZE:      0000104 00000004 d _Z5func1i
+# NM-SIZE-NEXT: 0000010c 0000000c D _Z5func1i
+# NM-SIZE-NEXT: 00000100 00000004 d value
+# NM-SIZE-NEXT: 00000118 00000004 D value
+# NM-SIZE-NEXT: 00000108 00000004 d weak_value
+# NM-SIZE-NEXT: 0000011c 00000004 W weak_value
----------------
I think it would be sufficient to only test a couple of symbols that have different sizes. You can leave out the others.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/size.test:23
+# NM-SIZE-NEXT: 0000011c 00000004 W weak_value
+~
----------------
Why's this line here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113104/new/

https://reviews.llvm.org/D113104