[PATCH] D114211: [llvm-diff] Implement diff of PHI nodes

[Bill Wendling via Phabricator via llvm-commits]

void added inline comments.


================
Comment at: llvm/test/tools/llvm-diff/phinode.ll:1
+; RUN: llvm-diff %s %s
+
----------------
dblaikie wrote:
> I'm not super faimiliar with llvm-diff - but I'm guessing this test passes before/after the change, so isn't testing the new functionality, is it? I guess some negative test cases should be tested instead to demonstrate that more parts of the IR are being tested?
I was a bit dumbfounded that this tool didn't have "negative" tests (except for the `callbr` for some reason). This test is almost entirely a smoke test—can it run without barfing on a PHI node? I'll see about creating a negative test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114211/new/

https://reviews.llvm.org/D114211