[PATCH] D114211: [llvm-diff] Implement diff of PHI nodes
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 19 09:24:13 PST 2021
dblaikie added inline comments.
================
Comment at: llvm/test/tools/llvm-diff/phinode.ll:1
+; RUN: llvm-diff %s %s
+
----------------
I'm not super faimiliar with llvm-diff - but I'm guessing this test passes before/after the change, so isn't testing the new functionality, is it? I guess some negative test cases should be tested instead to demonstrate that more parts of the IR are being tested?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114211/new/
https://reviews.llvm.org/D114211
More information about the llvm-commits
mailing list