[PATCH] D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

Thanks for catching this! This functionally does the right thing, but I think for consistency it would be better to spell it slightly differently



================
Comment at: utils/bazel/llvm-project-overlay/llvm/config.bzl:39
     "HAVE_UNISTD_H=1",
     "LLVM_WINDOWS_PREFER_FORWARD_SLASH=0",
 ]
----------------
So this is a noop? Maybe we should just leave it off then entirely then? There's also some housekeeping stuff that didn't get done in the commit you referenced. We usually keep track of the options in https://github.com/llvm/llvm-project/blob/main/utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h as well. They're either set directly there or it mentions that they're defined in Bazel. This whole system needs to be reworked, but better to stay consistent for now. If you wouldn't mind removing mentions of `LLVM_WINDOWS_PREFER_FORWARD_SLASH` in this file and adding it in the approrpiatel place in the config.h overlay file, that would be great (otherwise, I'll get to it at some point)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114065/new/

https://reviews.llvm.org/D114065