[PATCH] D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: GMNGeoffrey, tpopp.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

This cmake configure option was added in
df0ba47c36f6bd0865e3286853b76d37e037c2d7 <https://reviews.llvm.org/rGdf0ba47c36f6bd0865e3286853b76d37e037c2d7>, and was ported to
Bazel in 7d323dc7738e3152c4bd54a23ac27554bfbbf583 <https://reviews.llvm.org/rG7d323dc7738e3152c4bd54a23ac27554bfbbf583>.

However, the setting chosen in Bazel seems accidental, not necessarily
intentional.

LLVM_WINDOWS_PREFER_FORWARD_SLASH has no effect on Unix, and on
Windows, setting it to 0 is the default, which gets the same behaviour
as before. Setting it to 1 enables new experimental behaviours
(which is enabled by default on MinGW targets only).

As I don't see any explicit intent to opt in to the new experimental
behaviour, I believe the current configuration in bazel was a
mistake.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114065

Files:
  utils/bazel/llvm-project-overlay/llvm/config.bzl


Index: utils/bazel/llvm-project-overlay/llvm/config.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/config.bzl
+++ utils/bazel/llvm-project-overlay/llvm/config.bzl
@@ -71,7 +71,7 @@
     # LLVM features
     r'LTDL_SHLIB_EXT=\".dll\"',
     r'LLVM_PLUGIN_EXT=\".dll\"',
-    "LLVM_WINDOWS_PREFER_FORWARD_SLASH=1",
+    "LLVM_WINDOWS_PREFER_FORWARD_SLASH=0",
 ]
 
 # TODO: We should switch to platforms-based config settings to make this easier


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114065.387853.patch
Type: text/x-patch
Size: 510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211117/806dbfd8/attachment.bin>