[PATCH] D113932: [x86/asm] Let EmitMSInlineAsmStr() handle variants too

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D113932#3137501 <https://reviews.llvm.org/D113932#3137501>, @hans wrote:

> lgtm
>
> At what point does EmitGCCInlineAsmStr and EmitMSInlineAsmStr become similar enough that they could just take the desired variant as a parameter?

That's an excellent question. I think we (I) should merge them again. Some of the remaining differences might be more bugs. I'll look into this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113932/new/

https://reviews.llvm.org/D113932