[PATCH] D113932: [x86/asm] Let EmitMSInlineAsmStr() handle variants too

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm

At what point does EmitGCCInlineAsmStr and EmitMSInlineAsmStr become similar enough that they could just take the desired variant as a parameter?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:141
   unsigned NumOperands = MI->getNumOperands();
+  int AsmPrinterVariant = 1; // X86MCAsmInfo.cpp's AsmWriterFlavorTy::Intel.
 
----------------
Maybe this should be const?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113932/new/

https://reviews.llvm.org/D113932