[PATCH] D114017: [lld-macho][nfc] Factor-out NFC changes from main __eh_frame diff

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 16:28:12 PST 2021


oontvoo added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:217
+      // When an application provides its own personality function,
+      // it might be an extern Defined symbol reloc, or a local section reloc.
       if (auto *defined = dyn_cast<Defined>(s)) {
----------------
oontvoo wrote:
> could also be a Lazy symbol (D110040) ?
> 
(p.s : this is a question, not a request to change the comment :) )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114017/new/

https://reviews.llvm.org/D114017



More information about the llvm-commits mailing list