[PATCH] D114017: [lld-macho][nfc] Factor-out NFC changes from main __eh_frame diff

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo accepted this revision.
oontvoo added a comment.
This revision is now accepted and ready to land.

lg thanks!



================
Comment at: lld/MachO/InputFiles.cpp:694
 
-    InputSection *lastIsec = subsections.back().isec;
+    Subsection subsec = subsections.back();
+    InputSection *lastIsec = subsec.isec;
----------------
gkm wrote:
> oontvoo wrote:
> > (dont think it's necessary to copy it)
> Copying is only necessary to prevent 13 test cases from crashing ... 😵‍💫🤮
Oh, that's ... disturbing. why is it crashing(presumably asan issues?) ?
we're not holding on to the `subsec` (only  its `isec` field,  which is already a pointer )





================
Comment at: lld/MachO/UnwindInfoSection.cpp:217
+      // When an application provides its own personality function,
+      // it might be an extern Defined symbol reloc, or a local section reloc.
       if (auto *defined = dyn_cast<Defined>(s)) {
----------------
could also be a Lazy symbol (D110040) ?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114017/new/

https://reviews.llvm.org/D114017