[PATCH] D113958: DebugInfo: Make DWARFExpression::iterator a const iterator

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

Thanks for the reviews! Pushed in fd6018072ace7d5cdf537fd63a44c050a98e52fc <https://reviews.llvm.org/rGfd6018072ace7d5cdf537fd63a44c050a98e52fc>.

In D113958#3133946 <https://reviews.llvm.org/D113958#3133946>, @jhenderson wrote:

> Clang-format nit, as per linter.

Fixed!

> My only question is should it be renamed to `const_iterator` to avoid any confusion?

Tend to agree with @dblaikie that `iterator` is clear/simple so I left this as is.



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:133
 
-    class Operation &operator*() const {
+    const class Operation &operator*() const {
       return Op;
----------------
dblaikie wrote:
> Side note: the `class` keyword here could be removed.
Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113958/new/

https://reviews.llvm.org/D113958