[PATCH] D113295: [flang] Transform `fir.end` to an empty statement

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 16 08:22:06 PST 2021


schweitz added a comment.

In D113295#3134860 <https://reviews.llvm.org/D113295#3134860>, @awarzynski wrote:

> `fir.end` is only used in `fir.dispatch_table`, and `fir.dispatch_table` is currently a `notifyMatchFailure`, i.e. it's not implemented. I think that that's what we should do with `fir.end` as well. Let me update this accordingly. @schweitz , any thoughts?

Seems reasonable. `fir.end` used to be widely applicable, but it's steadily been eroded.

In fact, given https://llvm.discourse.group/t/rfc-making-terminator-optional-for-single-block-graph-regions/2997 it seems like `fir.end` will be end of life soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113295/new/

https://reviews.llvm.org/D113295



More information about the llvm-commits mailing list