[PATCH] D113295: [flang] Transform `fir.end` to an empty statement
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 16 07:31:01 PST 2021
awarzynski updated this revision to Diff 387635.
awarzynski added a comment.
Leave `fir.end` as unimplemented
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113295/new/
https://reviews.llvm.org/D113295
Files:
flang/lib/Optimizer/CodeGen/CodeGen.cpp
flang/test/Fir/convert-to-llvm-invalid.fir
Index: flang/test/Fir/convert-to-llvm-invalid.fir
===================================================================
--- flang/test/Fir/convert-to-llvm-invalid.fir
+++ flang/test/Fir/convert-to-llvm-invalid.fir
@@ -93,3 +93,10 @@
%0 = fir.gentypedesc !fir.type<derived3>
return
}
+
+// -----
+
+// Test `fir.end` conversion failure. Not implemented yet.
+
+// expected-error at +1{{failed to legalize operation 'fir.end'}}
+"fir.end"() : () -> ()
Index: flang/lib/Optimizer/CodeGen/CodeGen.cpp
===================================================================
--- flang/lib/Optimizer/CodeGen/CodeGen.cpp
+++ flang/lib/Optimizer/CodeGen/CodeGen.cpp
@@ -706,6 +706,18 @@
}
};
+/// Convert `fir.end`
+struct FirEndOpConversion : public FIROpConversion<fir::FirEndOp> {
+ using FIROpConversion::FIROpConversion;
+
+ mlir::LogicalResult
+ matchAndRewrite(fir::FirEndOp firEnd, OpAdaptor,
+ mlir::ConversionPatternRewriter &rewriter) const override {
+ return rewriter.notifyMatchFailure(
+ firEnd, "fir.end codegen is not implemented yet");
+ }
+};
+
/// Lower `fir.has_value` operation to `llvm.return` operation.
struct HasValueOpConversion : public FIROpConversion<fir::HasValueOp> {
using FIROpConversion::FIROpConversion;
@@ -1592,19 +1604,20 @@
mlir::OwningRewritePatternList pattern(context);
pattern.insert<
AbsentOpConversion, AddcOpConversion, AddrOfOpConversion,
- AllocaOpConversion, BoxAddrOpConversion, BoxCharLenOpConversion, BoxDimsOpConversion,
- BoxEleSizeOpConversion, BoxIsAllocOpConversion, BoxIsArrayOpConversion,
- BoxIsPtrOpConversion, BoxRankOpConversion, CallOpConversion,
- CmpcOpConversion, ConvertOpConversion, DispatchOpConversion,
- DispatchTableOpConversion, DTEntryOpConversion, DivcOpConversion,
- EmboxCharOpConversion, ExtractValueOpConversion, HasValueOpConversion,
- GenTypeDescOpConversion, GlobalLenOpConversion, GlobalOpConversion,
- InsertOnRangeOpConversion, InsertValueOpConversion,
- IsPresentOpConversion, LoadOpConversion, NegcOpConversion,
- MulcOpConversion, SelectCaseOpConversion, SelectOpConversion,
- SelectRankOpConversion, SelectTypeOpConversion, StoreOpConversion,
- SubcOpConversion, UnboxCharOpConversion, UndefOpConversion,
- UnreachableOpConversion, ZeroOpConversion>(typeConverter);
+ AllocaOpConversion, BoxAddrOpConversion, BoxCharLenOpConversion,
+ BoxDimsOpConversion, BoxEleSizeOpConversion, BoxIsAllocOpConversion,
+ BoxIsArrayOpConversion, BoxIsPtrOpConversion, BoxRankOpConversion,
+ CallOpConversion, CmpcOpConversion, ConvertOpConversion,
+ DispatchOpConversion, DispatchTableOpConversion, DTEntryOpConversion,
+ DivcOpConversion, EmboxCharOpConversion, ExtractValueOpConversion,
+ FirEndOpConversion, HasValueOpConversion, GenTypeDescOpConversion,
+ GlobalLenOpConversion, GlobalOpConversion, InsertOnRangeOpConversion,
+ InsertValueOpConversion, IsPresentOpConversion, LoadOpConversion,
+ NegcOpConversion, MulcOpConversion, SelectCaseOpConversion,
+ SelectOpConversion, SelectRankOpConversion, SelectTypeOpConversion,
+ StoreOpConversion, SubcOpConversion, UnboxCharOpConversion,
+ UndefOpConversion, UnreachableOpConversion, ZeroOpConversion>(
+ typeConverter);
mlir::populateStdToLLVMConversionPatterns(typeConverter, pattern);
mlir::arith::populateArithmeticToLLVMConversionPatterns(typeConverter,
pattern);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113295.387635.patch
Type: text/x-patch
Size: 3608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211116/1abfd1c9/attachment.bin>
More information about the llvm-commits
mailing list