[PATCH] D113525: [NFC][regalloc] Factor eviction decision-making into an analysis

Mon Nov 15 11:25:57 PST 2021

mtrofin added a comment.

In D113525#3132118 <https://reviews.llvm.org/D113525#3132118>, @davidxl wrote:

> To minimize text diff, may I suggest the following steps:
>
> 1. split out the changes that mechanically move the common declarations (such as enums) into the header
>
> 2. do not introduce the new .cpp file in the patch, but instead, leave the Advisor code in the original file. For instance EvictAdvisor::CanReassign 's definition stays in RegAllocGreedy.cpp.
>
> 3. As a follow up, mechanically move the functions to a new cpp file.
>
> This makes reviewing 2) more easily.

Makes sense - I'll start in order, then, referencing the RFC and then progressively rebasing this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113525/new/

https://reviews.llvm.org/D113525