[PATCH] D113525: [NFC][regalloc] Factor eviction decision-making into an analysis

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 10:15:14 PST 2021


davidxl added a comment.

To minimize text diff, may I suggest the following steps:

1. split out the changes that mechanically move the common declarations (such as enums) into the header

2. do not introduce the new .cpp file in the patch, but instead, leave the Advisor code in the original file. For instance EvictAdvisor::CanReassign 's definition stays in RegAllocGreedy.cpp.

3. As a follow up, mechanically move the functions to a new cpp file.

This makes reviewing 2) more easily.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113525/new/

https://reviews.llvm.org/D113525



More information about the llvm-commits mailing list