[PATCH] D113192: [DAG] MatchRotate - support rotate-by-constant of illegal types

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 15 08:33:48 PST 2021


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rv64zbp.ll:1863
 ; RV64ZBP:       # %bb.0:
-; RV64ZBP-NEXT:    greviw a0, a0, 16
+; RV64ZBP-NEXT:    roriw a0, a0, 16
 ; RV64ZBP-NEXT:    ret
----------------
@craig.topper Is this change OK? The test is called grev16_32 and neither target generates a grev op.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113192/new/

https://reviews.llvm.org/D113192



More information about the llvm-commits mailing list