[PATCH] D113845: [X86] getAVX512Node() - find constant broadcasts to encourage load-folding

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:46230
+  unsigned EltSizeInBits = VT.getScalarSizeInBits();
+  if (!VT.isVector() || (EltSizeInBits % 8) != 0)
     return SDValue();
----------------
RKSimon wrote:
> pengfei wrote:
> > Can we handle no-pow-2 type?
> If we did see those cases I'd expect the ternlog code would already have crashed, but I'll add it to be sure.
Confirmed - canonicalizeBitSelect get called only after legalize ops, so the types will be legal and pow2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113845/new/

https://reviews.llvm.org/D113845