[PATCH] D113194: [DebugInfo][NFC] Prevent some tests from running in instruction-referencing mode

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 9 10:50:38 PST 2021


dblaikie added a comment.

In D113194#3119147 <https://reviews.llvm.org/D113194#3119147>, @jmorse wrote:

> Update to remove non-x86 tests from the set labelled as "only test without instruction referencing". The non-x86 tests will fail if they're run with instruction referencing, which is the correct behaviour at this time.
>
> What with this technically being NFC, without objection I'll land it tomorrow shortly before sending the RFC email out.

Generally once something's sent for review it should get some approval/review rather than "landing if no one objects" (general community standards - as this can lead to folks sending something out for review and then submitting things without review only because review was slow, not because the patch didn't need review)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113194/new/

https://reviews.llvm.org/D113194



More information about the llvm-commits mailing list