[PATCH] D113194: [DebugInfo][NFC] Prevent some tests from running in instruction-referencing mode

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 9 10:45:19 PST 2021


jmorse added a comment.

In D113194#3111358 <https://reviews.llvm.org/D113194#3111358>, @djtodoro wrote:

> Regarding this change, overall it looks good to me. I am not sure what is the exact/official strategy inside LLVM community, but (I guess) if the test coverage isn't significantly broken it can be addressed as a future work by converting all the (interesting) tests into new MIR (with the new DBG instructions).

I'd really enjoy some of these .ll tests becoming MIR tests; it's a considerable effort though, as things like DebugInfo/X86/stack-value-dwarf2.ll have a single CHECK line and no context to explain the intention behind what they're checking.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113194/new/

https://reviews.llvm.org/D113194



More information about the llvm-commits mailing list