[PATCH] D113167: [lld-macho]Allow exporting weak_def_can_be_hidden(AKA "autohide") symbols

Fri Nov 12 16:58:44 PST 2021

oontvoo added a comment.

In D113167#3128638 <https://reviews.llvm.org/D113167#3128638>, @smeenai wrote:

>> x  10         84.01         89.41         88.64        87.693     1.7424061
>> +  10          71.9         74.29         72.63        72.753    0.77734663
>> Difference at 95.0% confidence
>> 	-14.94 +/- 1.26763
>> 	-17.0367% +/- 1.44553%
>> 	(Student's t, pooled s = 1.34912)
>>
>>   
>
> Am I reading that table incorrectly, or do you consider a 17% improvement to be small? :)

No, 17% is correct :)

================
Comment at: lld/MachO/Symbols.h:163

+  bool weakDefCanBeHidden : 1;
+
----------------
smeenai wrote:
> smeenai wrote:
> > int3 wrote:
> > > hmm, this brings us to 9 bits of booleans :/
> > > 
> > > probably fine in practice, but maybe do a quick benchmark before landing this
> > It won't change the size of the struct, cos of padding. Turns out these structs are laid out suboptimally with regards to padding though; I'll put up a diff to fix that.
> D113813
> D113813
Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113167/new/

https://reviews.llvm.org/D113167