[PATCH] D113167: [lld-macho]Allow exporting weak_def_can_be_hidden(AKA "autohide") symbols

Fri Nov 12 15:55:02 PST 2021

smeenai added inline comments.

================
Comment at: lld/MachO/Symbols.h:163

+  bool weakDefCanBeHidden : 1;
+
----------------
smeenai wrote:
> int3 wrote:
> > hmm, this brings us to 9 bits of booleans :/
> > 
> > probably fine in practice, but maybe do a quick benchmark before landing this
> It won't change the size of the struct, cos of padding. Turns out these structs are laid out suboptimally with regards to padding though; I'll put up a diff to fix that.
D113813

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113167/new/

https://reviews.llvm.org/D113167