[PATCH] D113651: [DwarfCompileUnit] getOrCreateCommonBlock(): check for existing entity first. NFCI

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

I'd probably separate these two commits - one's updating a comment to reflect the reality of the code, the other is changing unrelated code (which, while NFCI, is a change & would be easier to track if it breaks buildbots, etc, if it's separate)

feel free to commit the global variable comment change without sending a separate review/etc

As for the common block one - yeah, that sounds OK if it's a reasonable invariant that the scope could never create the entity being created here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113651/new/

https://reviews.llvm.org/D113651