[PATCH] D113651: [DwarfCompileUnit] getOrCreateCommonBlock(): check for existing entity first. NFCI
Kristina Bessonova via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 12 00:53:38 PST 2021
krisb added a comment.
> Mixed feelings about possible implications of making a (albeit NFCI) code change to match a comment rather than changing the comment to match the code. But to make this case consistent with the other cases the comment was copy/pasted from, sure let's go with this
Heh, this didn't seem harmful to me by the first look, but now I'm starting thinking that we may get a lot of additional map queries if the parent-child chain (for the context) is long enough.
I guess it is not possible to create a global variable through getOrCreateContextDIE() atm, the same is for fortran's common blocks. So, let's make an exception from the pattern for them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113651/new/
https://reviews.llvm.org/D113651
More information about the llvm-commits
mailing list