[PATCH] D113703: [RISCV] Reduce duplicate FP test cases.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 11:21:38 PST 2021


craig.topper created this revision.
craig.topper added reviewers: asb, jrtc27, luismarques, frasercrmck.
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, StephenFan, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar.
craig.topper requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: LLVM.

Remove tests from *-intrinsics.ll that are already tested in
*-arith.ll. This includes sqrt, fma, fmaxnum, fminnum, fabs, and
copysign. Alternatively, we could go the other way. My main
deciding point was that one test in *-arith.ll uses fcopysign and
fneg to test fsgnjn which felt like it should be in *-arith.ll

Remove feq, fle, flt tests from *-arith.ll in favor of *-fcmp.ll
which tests all predicates. I went the other way on this since
it seemed logical to expect all the fcmp tests in one file.
*-intrinsics seemed more vague.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113703

Files:
  llvm/test/CodeGen/RISCV/double-arith.ll
  llvm/test/CodeGen/RISCV/double-intrinsics.ll
  llvm/test/CodeGen/RISCV/float-arith.ll
  llvm/test/CodeGen/RISCV/float-intrinsics.ll
  llvm/test/CodeGen/RISCV/half-arith.ll
  llvm/test/CodeGen/RISCV/half-intrinsics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113703.386605.patch
Type: text/x-patch
Size: 43570 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211111/332db5eb/attachment.bin>


More information about the llvm-commits mailing list