[PATCH] D113644: [NFC][InlineAdvisor] Inform advisor when the module is invalidated

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D113644#3124903 <https://reviews.llvm.org/D113644#3124903>, @aeubanks wrote:

> It looks like the expensive part is recalculating `FunctionPropertiesAnalysis` in `getLocalCalls()`. Since you're only using `DirectCallsToDefinedFunctions`, could you implement that yourself rather than relying on the potentially expensive `FunctionPropertiesAnalysis`? For example, it looks like it needs to construct all the loops in the function which could be expensive.
> Counting by hand the number of direct calls should be quick and unnoticeable in terms of compile time.

You mean avoid using the analysis infra altogether there? I could, but:

- I'd still need to compute stuff unnecessarily in this scenario
- we may later want to rely on some other analysis results, so we'd be back to this place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113644/new/

https://reviews.llvm.org/D113644